Skip to content

IRGen: Fix anonymous context descriptors of alwaysEmitIntoClient functions #78017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

aschwaighofer
Copy link
Contributor

Relative references from context descriptors to types outside of the current module need to use indirect relative references

rdar://140356479

…tions

Relative references from context descriptors to types outside of the
current module need to use indirect relative references

rdar://140356479
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aschwaighofer
Copy link
Contributor Author

@swift-ci test linux

@aschwaighofer aschwaighofer merged commit fe00d20 into swiftlang:main Dec 10, 2024
5 checks passed
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Dec 10, 2024
…t functions

Explanation: Relative references from context descriptors to types outside of the
current module need to use indirect relative references. If direct
relative references are used instead linking will fail.

Scope: This situation can occurr with alwaysEmitIntoClient functions
returning opaque types combined with availability and the use of
-enable-anonymous-context-mangled-names (which is enabled at Onone).

Reviewer: John M.

Original PR: swiftlang#78017

Risk: Low. Should only affect cases that would have previously failed to
link.

rdar://140356479

(cherry picked from commit d31e4a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants