Skip to content

[OSSACompleteLifetime] Handle scoped addresses. #78034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

nate-chandler
Copy link
Contributor

Complete scopes of scoped addresses (introduced by store_borrow and begin_access) in dead end blocks via ScopedAddressValue::computeTransitiveLiveness.

rdar://141037060

And deleted some type annotations which don't need to be checked.
Use a switch rather than several ifs.
In preparation for adding a second caller.
Avoid a separate declaration.
Complete scopes of scoped addresses (introduced by `store_borrow` and
`begin_access`) in dead end blocks via
`ScopedAddressValue::computeTransitiveLiveness`.

rdar://141037060
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@eeckstein
Copy link
Contributor

Thanks!

@nate-chandler nate-chandler marked this pull request as ready for review December 9, 2024 15:03
@nate-chandler nate-chandler removed the request for review from jckarter December 9, 2024 15:03
Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nate-chandler nate-chandler merged commit 159259a into swiftlang:main Dec 9, 2024
8 checks passed
@nate-chandler nate-chandler deleted the rdar141037060 branch December 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants