Skip to content

[6.1][build-script] Stop installing the llbuildSwift library that is no longer used #78038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

finagolfin
Copy link
Member

Explanation: This installed library in the toolchain has been unused on linux and macOS for years.

Scope: Remove a single unused library from the linux and macOS toolchains

Issue: None

Original PRs: #77647

Risk: Very low

Testing: Passed all CI on trunk

Reviewer: @bnbarham

@DougGregor, another unused library cleanup.

@finagolfin finagolfin requested a review from a team as a code owner December 7, 2024 02:47
@finagolfin
Copy link
Member Author

@swift-ci please test

@finagolfin
Copy link
Member Author

@swift-ci please test windows

@finagolfin
Copy link
Member Author

@swift-ci test windows

@finagolfin
Copy link
Member Author

@shahmishal, passed CI (this pull does nothing on Windows, which doesn't use build-script), wdyt?

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing this unused library. It's not something we've advertised or maintained, and is unlikely to have any clients.

@DougGregor DougGregor merged commit fd0aa62 into swiftlang:release/6.1 Dec 11, 2024
5 checks passed
@finagolfin finagolfin deleted the release/6.1 branch December 12, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants