Some OSSA related optimization improvements #78054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
meg-gupta
reviewed
Dec 9, 2024
...CompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyBeginAndLoadBorrow.swift
Outdated
Show resolved
Hide resolved
|
Awesome! I left some minor comments but this LGTM! |
meg-gupta
reviewed
Dec 9, 2024
…eline. It triggers a false alarm when building SwiftDocC on linux rdar://141270464
…well This doesn't give any performance benefit.
The first step: allow hoisting instructions which only have trivial operands and results.
…truct for trivial tuples/structs Replace destructure_tuple with tuple_extract instructions and destructure_struct with struct_extract instructions. This canonicalization helps other optimizations to e.g. CSE tuple_extract/struct_extract.
* Remove dead `load_borrow` instructions (replaces the old peephole optimization in SILCombine) * If the `load_borrow` is followed by a `copy_value`, combine both into a `load [copy]`
…n_to_thick_function` `thin_to_thick_function` has "none" ownership and is compatible with guaranteed values. Therefore the `begin_borrow` is not needed.
eeckstein
force-pushed
the
ossa-opt-improvements
branch
from
72e63d7 to
3e35df0
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several (relatively) small optimization improvements to better deal with OSSA:
load_borrowanddestroy_addrload_borrowcopy_valueandbegin_borrowcorrectlydestructure_tupleanddestructure_structfor trivial tuples/structsload_borrowbegin_borrowif the borrowed value is athin_to_thick_functionbegin_borrowsimplification in SILCombineFor details see the commit messages.
This is part of fixing benchmark regressions when enabling OSSA modules.
rdar://139773406