Add support for serializing debug_value instructions #78056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usama54321
requested review from
kubamracek,
nkcsgexi,
adrian-prantl and
eeckstein
usama54321
force-pushed
the
usama54321/debug-value-serialization
branch
from
1ec3fcc to
9e6d297
Compare
|
Need to write tests for the initial commit + 4 bugfixes |
usama54321
force-pushed
the
usama54321/debug-value-serialization
branch
from
9fcea0b to
0d8c087
Compare
usama54321
requested review from
xymus,
jckarter and
rjmccall
as code owners
|
@swift-ci test |
usama54321
force-pushed
the
usama54321/debug-value-serialization
branch
from
0d8c087 to
47e5bcb
Compare
|
@swift-ci test |
usama54321
changed the title
usama54321
force-pushed
the
usama54321/debug-value-serialization
branch
from
174d75e to
10c9e56
Compare
|
@swift-ci test please |
|
@swift-ci test |
in the absence of a debug variable source loc, the instruction's loc gets applied as the debug variable's loc which is incorrect. This patch appropriately serializes the debug variable loc when possible and reverts to the default behavior otherwise. Also adds a test for debug_value serialization/deserialization
deserialization contains AST information which is needed in certain cases. Do not overwrite the debug scope in that case
usama54321
force-pushed
the
usama54321/debug-value-serialization
branch
from
10c9e56 to
a44406b
Compare
|
@swift-ci test |
This reverts commit c1682c7.
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for serialization and deserialization of debug value instructions