SIL: avoid truncation warnings on Windows (NFCI) #78060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`enum` is a signed integer type on some platforms. The return value of `std::numeric_limits<T>::max()` is a `size_t` which is unsigned. Further manipulation retains the unsigned-ness until the assignment which results in truncation. Change the type to a `constexpr` constant definition and remove the `enum` type along with a type conversion to an explicitly unsigned integral type.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enumis a signed integer type on some platforms. The return value ofstd::numeric_limits<T>::max()is asize_twhich is unsigned. Further manipulation retains the unsigned-ness until the assignment which results in truncation. Change the type to aconstexprconstant definition and remove theenumtype along with a type conversion to an explicitly unsigned integral type.