Error on duplicate module names in Swift module maps #78086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test Linux Platform |
|
@swift-ci please test Windows Platform |
|
@swift-ci please smoke test macOS Platform |
tshortli
reviewed
Dec 10, 2024
rmaz
force-pushed
the
failondupemodule
branch
from
c4996fd to
8ef0952
Compare
|
@swift-ci please smoke test macOS Platform |
drodriguez
approved these changes
Dec 10, 2024
test/ScanDependencies/cannot_import_with_map_duplicate_entries.swift
Outdated
Show resolved
Hide resolved
rmaz
force-pushed
the
failondupemodule
branch
from
8ef0952 to
fed08ca
Compare
|
@swift-ci please test |
Duplicate module names on search paths produces an error, but providing duplicate module names in a Swift explicit module map file does not, instead the first entry will be chosen. Modify the module map parser to error on duplicated module names as well.
rmaz
force-pushed
the
failondupemodule
branch
from
fed08ca to
8dd9a12
Compare
|
@swift-ci please test |
facebook-github-bot
pushed a commit
to facebook/buck2-prelude
that referenced
this pull request
Jan 2, 2025
Summary: This workaround is no longer required, the functionality was upstreamed in swiftlang/swift#78086 Reviewed By: narissiam Differential Revision: D67331330 fbshipit-source-id: b817fb7bf924c7cde67e87a139e201f4328c6850
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jan 2, 2025
Summary: This workaround is no longer required, the functionality was upstreamed in swiftlang/swift#78086 Reviewed By: narissiam Differential Revision: D67331330 fbshipit-source-id: b817fb7bf924c7cde67e87a139e201f4328c6850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate module names on search paths produces an error, but providing duplicate module names in a Swift explicit module map file does not, instead the first entry will be chosen. Modify the module map parser to error on duplicated module names as well.