-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Don't merge [benchmark] Compile and run benchmark on Linux #7810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
281 commits
Select commit
Hold shift + click to select a range
7cdc55d
Support opaque values inside open existential boxes
1c6757f
Merge pull request #7812 from DougGregor/self-derived-constraints
DougGregor c5f452b
-debug-time-compilation: Fix 2f21735 to actually distinguish phases.
jrose-apple 9cd2dda
Merge pull request #7814 from benrimmington/patch-1
swift-ci 2684564
[indexer] report defs/refs of parameters without a separate external …
9163017
Merge pull request #7819 from jrose-apple/time-for-an-update
swift-ci 1282c6a
tests: convert more tests to use new mangling for llvm types
eeckstein 79b5ea0
[PrintAsObjC] Handle generic parameters in extensions. (#7818)
jrose-apple e0e424a
[test] Only running the test on watchOS simulator (#7801)
moiseev 9c39793
Merge pull request #7821 from eeckstein/convert-tests
swift-ci eedf288
Merge pull request #7820 from nathawes/rdar30098853
37081f4
Merge pull request #7817 from shajrawi/existential_box_opaque
0165578
[Driver] Move some function-local state into PerformJobState.
graydon 935d7b4
[test] Temporarily disable test IRGen/witness_method.sil.
8cf9995
Merge pull request #7816 from bitjammer/reenable-threadsafe-caching-test
bitjammer c43c223
[sil-mode] Change [attribute] highlighting to use a non-greedy + so t…
gottesmm 455c126
[semantic-sil] Pass the uncasted argument as an @owned arg in the fai…
gottesmm c958cd6
[Syntax] Allow UnknownSyntax to have children
bitjammer a97fa06
[GSB] Factor out the checking of of the concrete-type constraints.
DougGregor 6295f3d
Revert "[test] Remove CPU=i386_or_x86_64 hack."
fbe945b
Merge pull request #7824 from bitjammer/sr-4062-unknown-syntax-children
bitjammer 252af7d
Merge pull request #7617 from natecook1000/nc-hash-quadtest
natecook1000 a13a0df
[Driver] Factor out some Job-logging support.
graydon 9b45a64
[Driver] Adjust expected driver tracing output in tests.
graydon de2c05f
[Driver] Extract scheduleCommandIfNecessary and add logging.
graydon aee4c83
[Driver] Move markFinished to PerformJobsState, add logging.
graydon 053c3f8
[Driver] Move DepGraph and MarkTracer to PerformJobsState.
graydon e81d0f4
[Driver] Pass Tracer to markTransitive everywhere.
graydon b8c26ef
[Driver] Move more temp Job sets to PerformJobsState.
graydon f7e9598
[Driver] Clean up some comments.
graydon 6d21711
[Driver] Move TaskQueue callbacks to PerformJobsState.
graydon 1b3a434
[Driver] Factor out PerformJobsState::schedule*Jobs.
graydon f83ee9f
[Driver] Factor out PerformJobsState::runTaskQueueToCompletion.
graydon 9d0e7e0
[Driver] Factor out PerformJobsState::checkUnfinishedJobs.
graydon 211d097
[Driver] Move populateInputInfoMap into PerformJobsState.
graydon ab5201f
[Driver] Make PerformJobsState a mostly-private class.
graydon 423d9fe
[Driver] Extract reloadAndRemarkDeps from taskFinished.
graydon 4583e91
[Driver] Extract dependencyLoadFailed, add optional warning.
graydon a381aa1
[Driver] Differentiate logging of the special "" provided member.
graydon 2d06da7
demangler: be a bit more verbose when printing the simplified manglin…
eeckstein 00b72b3
[benchmark] Fix incorrect results check
natecook1000 1d62b91
Fix REQUIRES line in a test to work with newer LLVM.
bob-wilson cdb38c1
[GSB] Check all superclass constraints during finalization.
DougGregor c28095b
Merge pull request #7825 from gparker42/i386_or_x86_64-again
2d7491e
Merge pull request #7828 from eeckstein/thunk-demangling
swift-ci 4240d01
Merge pull request #7829 from gottesmm/checked_cast_br_1
swift-ci 48e7d40
support materializing set's getters/setters for opaque value types
d1627dc
[GSB] Check superclass constraints against concrete constraints.
DougGregor 583f740
[indexer] Add RelationContainedBy from references to their containing…
63e8a6e
Merge pull request #7830 from apple/nc-test-fix
swift-ci 32f063c
Merge pull request #7831 from bob-wilson/fix-requires-syntax
bob-wilson 775ed71
Merge pull request #7832 from shajrawi/materializeForSet_setter
7980623
Add FIXME(string) to the skipped String tests
mtake 75756d6
Merge pull request #7834 from nathawes/rdar30765261
ab6f7c4
IRGen: Cache concrete witness tables using the local metadata mechanism
slavapestov b722b7f
Add support for writeback of opaque value types in LogicalPathComponent
af53cb9
Merge pull request #7733 from rintaro/parse-ifconfig-refactoring
swift-ci ad38436
Merge pull request #7838 from shajrawi/writeback_opaque
6142329
[Type checker] Finalize the GenericSignatureBuilder for @_specialize.
DougGregor e305a4d
SILOptimizer: Add support for generic closures to CapturePromotion
slavapestov 352449d
AST: Remove unnecessary getCanonicalType() call
slavapestov 4138381
SIL: Remove SILType::substFuncType()
slavapestov 888f504
[docs] Fix gybbo in UnsafeRawBufferPointer docs
natecook1000 a2b594a
Merge pull request #7833 from DougGregor/superclass-constraints
swift-ci 1c3aa1b
Merge pull request #7840 from apple/nc-unsafemutablerawpointer
swift-ci fc16cb5
Sema: Let `.foo` patterns fall back to being ExprPatterns if they don…
jckarter d608765
Merge pull request #7835 from slavapestov/irgen-concrete-conformance-…
slavapestov 15b46e3
Merge pull request #7839 from slavapestov/generic-capture-promotion
slavapestov 581675e
SIL: Fix latent bug in SILType::subst()
slavapestov ec1d9fc
SIL: Remove TypeConverter::substFunctionType()
slavapestov 2b5d974
SIL: SILType::subst() can now take a generic signature
slavapestov 5dea03e
SIL: Use SILType::subst() to implement SILFunction::mapTypeIntoContext()
slavapestov 8c10274
SIL: Address FIXME in SILBoxType::getFieldLoweredType()
slavapestov af33162
Merge pull request #7842 from slavapestov/sil-type-subst-works-so-use-it
slavapestov 7c844fc
SILOptimizer: Use the SubstitutionMap form of substGenericArgs()
slavapestov d945522
Refactor SampleRunner into POSIX and Darwin versions
mtake 65f05b3
Add Timer class for portability between Darwin and POSIX platforms
mtake ec4bf00
[AST] Eliminate unnecessary #includes of AST/ProtocolConformance.h.
DougGregor c6dc44d
Merge pull request #7841 from jckarter/leading-dot-pattern-fallback
jckarter 1f3c662
[LangOptions] Introduce a new enum class for platform conditions (#7843)
rintaro 99df208
[Driver] Clear deferred commands on each task queue iteration.
graydon ec5d4f3
[Driver] Put new job-lifecycle diagnostic chatter behind another option.
graydon 1c3a54b
[Driver] Only warn on .swiftdeps load-fail with -driver-show-incremen…
graydon 548e956
Attempt to fix bots that are seeing XPASS on two tests
benlangmuir ba6ad0d
Merge pull request #7845 from benlangmuir/disable-xpass
swift-ci 400bb13
Merge pull request #7844 from slavapestov/one-last-cleanup
slavapestov 85805f3
[indexer] Fix missing references for inherits of associated types
779177d
Use a SmallVector rather than SmallDenseMap to hold solver scopes.
rudkx 0939e87
Merge pull request #7768 from kconner/fix-omitted-word-in-ownership-m…
slavapestov be986d7
demangler: add an API to check if a function has the swiftcc calling …
eeckstein f8f172a
demangler: also support the future mangling prefix ‘_S’
eeckstein 348c6b8
Protocol conformance: store conformances needed for the requirement s…
DougGregor 5b44e35
SIL: Fix verifier crash with metatypes of dynamic Self
slavapestov 6e44e54
Fix several metatype to objects that didn't use cleanups.
gottesmm fa0ec5d
[docs] Update replaceRange to replaceSubrange
natecook1000 babf6ff
Merge pull request #7827 from graydon/compilation-cleanup
graydon b20882b
Fix horrible sneaky use-of-temporary-after-destruction in SWIFT_DEFER…
jrose-apple 772243f
[silgen] Fix deallocating destructor emission to begin a borrow scope…
gottesmm 6c37640
Merge pull request #7854 from slavapestov/small-sil-verifier-fix
slavapestov c9dad65
IDETypeChecking: fix a memory leak. (#7849)
nkcsgexi a34697b
Merge pull request #7850 from eeckstein/demangle-swiftcc
eeckstein 0c0d131
Merge pull request #7856 from gottesmm/destructor_fixups
gottesmm 2423045
Merge pull request #7855 from apple/nc-rrc-replacerange
swift-ci 0130407
Make FloatingPoint imply Hashable. SR-4132.
stephentyrone df8efc2
Merge pull request #7846 from nathawes/rdar25616751
4bc12ae
[sil] Add end_lifetime.
gottesmm f92693a
[silgen] Balance out the +1 from the self argument in deallocating de…
gottesmm cbcea38
Merge pull request #7858 from gottesmm/end_lifetime_and_deallocating_…
swift-ci 98f77ab
[serialization] Bump version_minor for end_lifetime.
gottesmm 302eadf
Merge pull request #7859 from gottesmm/bump_version_minor
swift-ci 2ee4add
[Constraint solver] Simplify removeGeneratedConstraint.
rudkx 01764eb
Merge pull request #7848 from rudkx/clean-up-scope-handling
rudkx 3376738
[build-script-impl] Add support for building benchmarks on linux but …
gottesmm 5dbc58c
[build-script] Add preset for building swift and the benchmarks and r…
gottesmm 2561edd
Merge pull request #7861 from rudkx/simplify-remove-generated-constra…
swift-ci ce718ee
Merge branch 'master' into normal-conformance-requirement-signature
DougGregor 33d7246
Merge pull request #7853 from DougGregor/normal-conformance-requireme…
swift-ci e626dd5
Rename ValidatedTypes/validateTypeForLayout to make the
rjmccall 6707eb0
Fix a bug introduced by the recursive-protocol validation
rjmccall fe7915d
Rework a number of SIL and IRGen witness-table abstractions
rjmccall 13111c2
Merge pull request #7852 from rjmccall/sil-irgen-generalized-proto-re…
swift-ci 281c5cf
[swiftc (60 vs. 5458)] Add crasher in swift::GenericSignatureBuilder:…
practicalswift df4b775
Merge pull request #7863 from practicalswift/swiftc-28706-conformance…
practicalswift fd71d24
[swiftc (61 vs. 5458)] Add crasher in swift::DiagnosticEngine::emitDi…
practicalswift 12ae9b4
Add Windows target and toolchain
hughbe e037169
Add clang-cl to list of possible C/C++ compilers for Windows
hughbe bb34e2a
Fix attribute fallout from new refcount representation
hughbe 8d40749
Misc fixes to the runtime for MSVC compatability with it's public hea…
hughbe 6881ad1
Merge pull request #7865 from practicalswift/swiftc-28707-false-encou…
swift-ci 817adc2
Merge pull request #7866 from hughbe/refcnt-attribute
swift-ci 4b3d61b
[gardening] Fix accidental \t
practicalswift d15f09c
Merge pull request #7867 from hughbe/metadata
swift-ci 8507c93
[gardening] Add C++ language marker to .h file
practicalswift 9f21cae
[gardening] Fix incorrect file name in header
practicalswift 1475ab6
[gardening] Remove duplicate #include:s
practicalswift 17b6160
[gardening] Remove unused method replaceValue(..., ...)
practicalswift 00a48e7
[gardening] Remove unused variable pinResult
practicalswift ac12480
Merge pull request #7869 from practicalswift/gardening-20170302
swift-ci cfd5418
Disable test/ClangImporter/blocks_parse until it can be fixed
benlangmuir 54b5a7d
Merge pull request #7873 from benlangmuir/disable-blocks-parse
swift-ci 9c2b471
[test] Logging a list of available features before executing the test…
moiseev 8fe97c4
AST: Make SubstitutionMap::lookupSubstitution() private
slavapestov cdc3c1b
Sema: Accept tautological assoc type inference candidates when same-t…
jckarter d6cc431
[FixCode] Enhance existing fill-protocol-stub fixit so that all missi…
nkcsgexi c88064b
Merge pull request #7875 from jckarter/assoc-type-inference-same-type…
jckarter d237167
Merge pull request #7874 from slavapestov/private-lookup-substitution
slavapestov f4e478e
swift-api-digester: use 0-based parameter index. rdar://30763215
nkcsgexi cac51bd
Implement function-parameter-list and friends in lib/Syntax
bitjammer 7ce3b81
Add generic Syntax collection for unbounded list of nodes
bitjammer e565392
[Syntax] Add convenience iterator for SyntaxCollections
bitjammer e70a658
[Syntax] function-parameter-list is now a SyntaxCollection
bitjammer 288da66
Implement function-signature in lib/Syntax
bitjammer b99df06
Update lib/Syntax/Status.md for function declarations
bitjammer 18ee4e1
Implement declaration-modifier(s) in lib/Syntax
bitjammer f900fbd
Implement function-declaration in lib/Syntax
bitjammer ceb3bab
[Syntax] Short diversion converting StmtListSyntax to a SyntaxCollection
bitjammer bb4253e
Convert generic-requirement-list to SyntaxCollection, implement funct…
bitjammer cfb5893
[silgen] Fix destroying destructor to use proper ownership with its @…
gottesmm a413122
demangler: add an API function to get the target of a thunk symbol.
eeckstein 9eeac18
Add a warning message if the elapsed time is 0
mtake 4e3f294
Merge pull request #7878 from bitjammer/sr-4067-function-declaration-…
bitjammer 20801a0
Revert to the original code and exclude it unless objc runtime is ava…
mtake 210c2e1
Merge pull request #7760 from hughbe/build-script-windows-platform
hughbe 0724ab6
Merge pull request #7880 from gottesmm/destroying_destructor_fixes
swift-ci 3ef0688
Merge pull request #7881 from eeckstein/thunk-demangling
eeckstein e955e53
[coverage] Add a preset for generating coverage data and have coverag…
gottesmm ef47c26
[test] Update the mock SDK's Dispatch to resemble the real one. (#7879)
jrose-apple 335a6c3
Merge pull request #7882 from gottesmm/coverage_fix
swift-ci 80e297d
[silgen] Go through and fix up places where during bringup of load_bo…
gottesmm ff5db8b
Merge pull request #7885 from gottesmm/load_borrow_fixups
swift-ci 6038e2d
Fix -Wextra-semi warnings.
akyrtzi 9f62e55
Fix -Wformat-pedantic warning.
akyrtzi 0f4a7d2
AST: Remove GenericSignature::getAllDependentTypes()
slavapestov 3246b72
[SR-3917] Allow missing witnesses for optional and unavailable requir…
DougGregor f0300be
Merge pull request #7884 from slavapestov/remove-get-all-dependent-types
slavapestov a9db867
Implement partial specialization behind a flag.
swiftix 5cef3fe
Merge pull request #7886 from DougGregor/sr-3917
swift-ci 8e439da
Merge pull request #7888 from swiftix/wip-partial-specialization-v77
swiftix 33f5f89
Update unreachable control path annotations
hughbe e29ffde
[SourceEntityWalker] Ignore implicit patterns when walking the AST us…
akyrtzi 21fa510
Merge pull request #7891 from akyrtzi/source-walk-ignore-implicit-pat…
swift-ci 2c44ad4
Merge pull request #7469 from bob-wilson/disable-checks-macro
bob-wilson e640c02
Mark compiler_crashers/28700 as non-deterministic
benlangmuir e367520
Merge pull request #7892 from benlangmuir/disable-28700
swift-ci 6668d14
Fix wacky indentation. NFC
DougGregor ebac070
Merge pull request #7894 from DougGregor/fix-wacky-indentation
DougGregor 56ffacc
Add fixed compiled crasher from rdar://problem/30702721.
DougGregor e935700
[SR-4087] fix "add @available attribute" location (#7864)
szotp 3020d33
Fix SyntaxCollection operator[] in no-asserts build
benlangmuir fe052f6
Mark compiler_crashers/28702 as non-deterministic
benlangmuir 092a273
Add regression test for SR-4143 with assoc types crossing inheritance…
jckarter 166f14d
Merge pull request #7897 from benlangmuir/disable-28702
swift-ci 255c814
Merge pull request #7896 from benlangmuir/fix-syntaxcollection-tests
benlangmuir 8ec3bd3
[FixCode] When fixing missing enum elements in a switch statement, pr…
nkcsgexi 9254a3b
Merge pull request #7895 from DougGregor/rdar30702721
swift-ci f662ed8
Sema: Assert that bridging constraints aren't formed when ObjC intero…
jckarter bc6ea5b
Merge pull request #7898 from jckarter/assoc-inference-protocol-refin…
jckarter 3456d04
"-swift-version 3" means Swift 3.1, not 3.0. (#7883)
jrose-apple d7387e0
Added device presets for LLDB that build the static device stdlib.
scallanan f220a3b
Demangler: further speed improvements.
eeckstein fe5b1f1
Merge pull request #7901 from jckarter/no-bridging-constraints-withou…
jckarter 254745d
Merge pull request #7904 from eeckstein/demangler-speedup
swift-ci 0f6aaef
Merge pull request #7903 from scallanan/with-devices-presets
scallanan 5a6867a
Merge pull request #7889 from hughbe/unreachable-030317
hughbe feb34d9
Fix typos/grammar in comments.
ChristopherRogers 5df3f38
Merge pull request #7908 from ChristopherRogers/fix-comments
swift-ci 0c56998
SIL: IWYU cl edition
compnerd 5247d8c
Merge pull request #7909 from compnerd/iwyu
swift-ci 9acb847
[swiftc (62 vs. 5458)] Add crasher in swift::TypeBase::getCanonicalTy…
practicalswift 8cf0a14
[gardening] Remove 16 unused diagnostics
practicalswift 75522a8
[gardening] Remove unused variable loweredMT
practicalswift 80e3cba
Sema: Fix 'super' calls from methods returning 'Self'
slavapestov cc3e37e
Merge pull request #7910 from practicalswift/swiftc-28709-unreachable…
swift-ci 75d0061
Merge pull request #7913 from slavapestov/super-wrong-upcast-fix
slavapestov 97fce6c
SILOptimizer: Always create SILFunctions with a generic environment
slavapestov 776d4cb
IRGen: Fix debug info emission bug with inlining of generics
slavapestov 50fb3b6
Merge pull request #7915 from slavapestov/debug-info-generics-inlinin…
slavapestov c5456e3
[index] Handle properly typealiases as inherited types
akyrtzi 4bd5e11
Merge pull request #7916 from akyrtzi/index-typelias-as-base
swift-ci 44f2397
SILCombiner: Clean up the concrete -> existential peephole a bit
slavapestov 4e5b49a
Merge pull request #7917 from slavapestov/sil-combiner-cleanup
slavapestov 66ff058
SILGen: Remove SubstFormalType computation
slavapestov 5113a1a
Merge pull request #7912 from practicalswift/remove-quite-a-few-unuse…
slavapestov d03ac2c
Merge pull request #7911 from practicalswift/remove-unused-variable-l…
slavapestov 5a624eb
Merge pull request #7918 from slavapestov/silgen-apply-cleanup
slavapestov 7af65d9
Merge pull request #7870 from stephentyrone/FloatingPoint-Hashable
6920290
[silgen] Add an assert to ManagedValue::ManagedValue saying that obje…
gottesmm 87ca878
[silgen] Fix another tuple explosion -> borrow + copy since we do not…
gottesmm 07bcac3
[semantic-sil] If SIL Ownership is disabled, return Any if a forwardi…
gottesmm a1cf6d3
[swift_build_support] Add support for building benchmarks on linux-x8…
gottesmm 014ec70
Merge pull request #7902 from gottesmm/mo_tuples_mo_problems
swift-ci 031ecc2
Merge pull request #7860 from gottesmm/build_script_impl_linux_benchm…
swift-ci 5db45a4
demangler: A few more cosmetic performance improvements.
eeckstein 871dc6f
Merge pull request #7922 from eeckstein/demangler-perf
swift-ci 85f3fd1
[SR-4166] Change on how __mode__ attribute presence is checked to fix…
gonzalolarralde dfcad1a
Mangler: print statistic about substitutions, which don’t fit into th…
eeckstein fcd79c0
Mangling: consider bound generic types for substitutions
eeckstein b9c9ec0
mangling: use meta programming for known-type substitutions
eeckstein a04a29a
mangling: efficient mangling of repeated substitutions
eeckstein 3f6ede7
Merge pull request #7923 from gonzalolarralde/SR-4166-error-compiling…
hughbe fdf2282
Remove now unecessary MSVC trailing objects workaround
hughbe b661af1
Merge pull request #7924 from eeckstein/mangling-improvements
swift-ci 4def042
Merge pull request #7890 from hughbe/msvc-workaround
swift-ci 0499acb
Make benchmark compile and run on Linux
mtake 9a33394
Add FIXME(string) to the skipped String tests
mtake 5b194ed
Refactor SampleRunner into POSIX and Darwin versions
mtake 7856ecd
Add Timer class for portability between Darwin and POSIX platforms
mtake 58d2f76
Add a warning message if the elapsed time is 0
mtake ba9ab90
Revert to the original code and exclude it unless objc runtime is ava…
mtake ce0bbba
Merge branch 'benchmark-on-linux' of github.com:mtake/swift into benc…
mtake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
//===--- HashQuadratic.swift ----------------------------------------------===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import TestsUtils | ||
|
||
let size = 3_000_000 | ||
|
||
@inline(never) | ||
public func run_HashQuadratic(_ N: Int) { | ||
for _ in 1...N { | ||
var dict1: [Int: Int] = [:] | ||
for i in 0..<size { | ||
dict1[i] = i * 2 | ||
} | ||
|
||
var dict2: [Int: Int] = [:] | ||
for (k, v) in dict1 { | ||
dict2[k] = v | ||
} | ||
|
||
CheckResults(dict1[size/2] == dict2[size/2], | ||
"Incorrect results in HashQuadratic") | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably better if practical to just
#if
out the entire functions if possible, and then just not call them on Linux, rather than call them with empty bodies.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@airspeedswift As described in the comment,
utils/main.swift
is generated from templates. My goal is to selectively skip compiling and running each test solely by itself while keeping templates and the generation utility unchanged. I think this is important to avoid any impact to the existing build and test framework.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future pull request, we should update the generation utility to support
#if
defining out entire benchmark functions.