[Indexing] Disable indexing textual-interface-blocklisted modules during Explicit Module Builds #78128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci smoke test |
…ing Explicit Module Builds If a module is blocklisted from the compiler using its textual interface, then under Implicitly-Built modules it will not get indexed, since indexing will not be able to spawn swiftinterface compilation. With explicitly-built modules, none of the dependency modules get built from interface during indexing, which means we directly index input binary modules. For now, for functional parity with Implicit Module Builds, disable indexing of modules during Explicit Module Builds which would not get indexed during Implicit Module Builds.
artemcm
force-pushed
the
NoIndexBlocklistedInterfaceModulesOnEBM
branch
from
da97c9a to
fdda02b
Compare
|
@swift-ci smoke test |
bnbarham
approved these changes
Dec 12, 2024
xymus
reviewed
Dec 12, 2024
| if (explicitModuleBuild && | ||
| ctx.blockListConfig.hasBlockListAction(moduleName, | ||
| BlockListKeyKind::ModuleName, | ||
| BlockListAction::ShouldUseBinaryModule)) |
There was a problem hiding this comment.
This blocklist is close enough but we'd have to add the problematic module. It's only on DowngradeInterfaceVerificationFailure as otherwise we don't use its swiftmodule by default.
xymus
approved these changes
Dec 12, 2024
|
@swift-ci smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module is blocklisted from the compiler using its textual interface, then under Implicitly-Built modules it will not get indexed, since indexing will not be able to spawn swiftinterface compilation. With explicitly-built modules, none of the dependency modules get built from interface during indexing, which means we directly index input binary modules.
For now, for functional parity with Implicit Module Builds, disable indexing of modules during Explicit Module Builds which would not get indexed during Implicit Module Builds.