[cxx-interop] Fix spurious ambiguous member lookup #78132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another reason I'm opening this PR separate from #77726 is because I want to test it independently in CI. This change seems to cause a cascade of other issues, apparently because the existing tests have come to depend on nested calls to As such, @swift-ci please test |
|
@swift-ci please test |
Also include a little more of the mangled symbol, for more precise testing + better readability of the `// CHECK: ` directives (though they are still pretty unreadable)
|
@swift-ci Please smoke test |
j-hui
changed the title
|
@swift-ci Please test |
j-hui
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci Please test |
Xazax-hun
reviewed
Dec 13, 2024
|
@swift-ci Please test |
|
@swift-ci Please test |
fahadnayyar
approved these changes
Dec 17, 2024
j-hui
added a commit
that referenced
this pull request
Jan 22, 2025
…ed members (#78673) Follow-up from #78132, which did not fix issues related to eagerly imported members like subscripts. This patch restructures recursive ClangRecordMemberLookup requests to importBaseMemberDecl() in the recursive calls, rather than propagating base member decls up to the initial lookup request and doing the import. Doing so seems to fix lingering resolution issues (which I've added to the regression tests). rdar://141069984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested calls to
importBaseMemberDecl()subvert its cache and compromise its idempotence, causing the semantic checker to spuriously report ambiguous member lookups when multipleClangRecordMemberLookuprequests are made (e.g., because of an unrelated missing member lookup).One such scenario is documented in the test case I checked into the test suite in f818a5d, which fails without this fix (in particular,
inherited-lookup-typechecker.swiftfails because of the expected error from themissingmember;inherited-lookup-executable.swiftworks because it does not attempt to access amissingmember).I noticed this bug in #77726 when I found that my
expected-errors seemed to be triggering this unrelated error. I'm breaking out a small piece of that PR because (1) it is getting quite large, (2) it is getting stale, and (3) I am trying to separate this bug fix from that feature work.rdar://141069984