[CMake] Fix some issues in new runtime build for Linux and Windows builds #78134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defaulted_set` wasn't expanding the default variable, just setting the value of the variable the name of the variable that should have been doing the defaulting.
These files are required in order to link libswiftCore regardless of whether ObjectiveC is required.
|
@swift-ci please smoke test |
compnerd
approved these changes
Dec 12, 2024
|
@swift-ci please test Linux |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some issues in the runtime build. The defaulted settings were not set right.
Also, not all of the ObjC files are actually ObjC or part of the ObjC interop. We need to build ErrorObject.mm and SwiftObject.mm as part of all builds or things don't link.