LoopRotate: remove redundant phis after ssa-update #78136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not belong to loop-rotate and does not work with OSSA. This peephole is covered by other optimizations.
To be able to use `!=` for operands.
…lues if all incoming values are the same This is needed after running the SSAUpdater for an existing OSSA value, because the updater can insert unnecessary phis in the middle of the original liverange which breaks up the original liverange into smaller ones: ``` %1 = def_of_owned_value %2 = begin_borrow %1 ... br bb2(%1) bb2(%3 : @owned $T): // inserted by SSAUpdater ... end_borrow %2 // use after end-of-lifetime! destroy_value %3 ``` It's not needed to run this utility if SSAUpdater is used to create a _new_ OSSA liverange.
Because it now has the replacePhisWithIncomingValues utility, which works for all kind of phis.
Fixes an ownership error
|
@swift-ci test |
|
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed after running the SSAUpdater in loop-rotate, because the updater can insert unnecessary phis in the middle of the original liverange of a value which breaks up the original liverange into smaller ones:
Fixes an ownership error.
Also, remove the replace-arg-with-struct peephole optimization from loop-rotate. It not belong to loop-rotate and does not work with OSSA. This peephole is covered by other optimizations.