[embedded] Include and use cxxshims in the embedded/ resource dir #78147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
hyp,
egorzhdan,
rauhul,
zoecarver and
eeckstein
kubamracek
requested review from
Xazax-hun,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
kubamracek
force-pushed
the
embedded-cxxshim
branch
from
28832de to
3aeb5e9
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not have the libcxxshim.h and the modulemap in the embedded/ resource dir (only in macos/, etc.) previously. This should resolve compiler crashes when we need to emit calls to
__swift_interopStaticCastwhile in Embedded Swift mode.Attached testcase without this fix crashes the compiler with: