[TypeChecker/SILGen] Allow any Sendable to match Any while matching generic arguments
#78171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndable` Prevent generic arguments from being assigned `any Sendable` directly, that should only happen through inference. This is required because we allow `any Sendable` -> `Any` conversion in modes without strict concurrency enabled to maintain source compatibility and let the developers annotate existing APIs with `any Sendable` and other concurrency attributes.
…ic arguments Allow `any Sendable` to match `Any` constraint while matching generic arguments i.e. `[any Sendable]` -> `[Any]` when `any Sendable` type comes from context that involves `@preconcurrency` declarations in non-strict concurrency compiler mode. Note that it's currently impossible to figure out precisely where `any Sendable` type came from.
`UnsafeCastExpr` - A special kind of conversion that performs an unsafe bitcast from one type to the other. Note that this is an unsafe operation and type-checker is allowed to use this only in a limited number of cases like: `any Sendable` -> `Any` conversions in some positions, covariant conversions of function and function result types.
…c arguments In non-strict concurrency mode when `@preconcurrency` declarations are involved `any Sendable` should be treated as `Any` in generic argument positions to support passing types that (partially) adopted concurrency annotations to types that haven't yet done so.
…ith ManagedValue
Forwarding cast handles ownership correctly and doesn't disable optimizations unlike bitcast.
…ainst marker protocol This indicates that the type doesn't have appropriate annotations i.e. for concurrency or ownership.
…of generic arguments Conversion restrictions like "deep equality" could produce a more narrow/actionable fixes.
…e same This helps to avoid spurious failures pointing to involved pattern types because they won't match exactly if shape types are not the same.
…ion in non-strict concurrency contexts
xedin
requested review from
hborla,
slavapestov,
jckarter,
ktoso and
tshortli
as code owners
|
We can use |
|
@swift-ci please test |
atrick
reviewed
Dec 13, 2024
|
@swift-ci please test |
xedin
force-pushed
the
rdar-140300022
branch
2 times, most recently
from
cbcb24f to
20a5a51
Compare
|
@swift-ci please test |
…ction argument/result positions in generic argument context
xedin
force-pushed
the
rdar-140300022
branch
from
20a5a51 to
0de9e9c
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility debug |
|
@swift-ci please test macOS platform |
…l language modes
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
any Sendableto matchAnyconstraint while matchinggeneric arguments i.e.
[any Sendable]->[Any]whenany Sendabletype comes from context that involves
@preconcurrencydeclarations.To facilitate that we need a new expression that models an unsafe bitcast
from one type to the other -
UnsafeCastExpr. This expression is goingto be introduced by the solver during solution application phase to
erase
any SendabletoAnyin generic argument positions.Resolves: rdar://140300022