6.1: [BitwiseCopyable] Fix resilient enum type info. #78174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like other `EnumTypeInfo`s, the `TypeInfo` subclasses `EnumTypeInfoBase` and store the `EnumImplStrategy`.
|
@swift-ci please test |
tbkka
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a compiler crash on resilient
BitwiseCopyableenum.TypeInfos for enums must store their correspondingEnumImplStrategys so that the latter can be looked up from theTypeInfo. Previously, theTypeInfofor resilientBitwiseCopyableenums was identical to theTypeInfofor all other kinds of types. This was incorrect because it didn't store theEnumImplStrategy. Here, a new sublcass is added which does store it as required.Scope: Affects adopters of BitwiseCopyable.
Issue: rdar://141228350
Original PR: #78130
Risk: Low. Follows the existing pattern for resilient enum
TypeInfo.Testing: Added test.
Reviewer: Arnold Schwaighofer ( @aschwaighofer )