[PrintAsObjC] Handle generic parameters in extensions. #7818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time, "generics" means "cannot be exposed to Objective-C" and certainly "cannot be exposed in the generated header", but there is one exception: imported Objective-C parameterized types, and their extensions. We were previously dropping this on the floor and printing `Foo</* BarType */>` in the generated header, which is nonsense. https://bugs.swift.org/browse/SR-3480
|
@swift-ci Please test |
jrose-apple
commented
Feb 28, 2017
| "extensions with custom generic parameters?"); | ||
| assert(extension->getGenericSignature()->getCanonicalSignature() == | ||
| extendedClass->getGenericSignature()->getCanonicalSignature() && | ||
| "constrained extensions or custom generic parameters?"); |
There was a problem hiding this comment.
@slavapestov, do these assertions look good?
slavapestov
approved these changes
Feb 28, 2017
DougGregor
reviewed
Mar 1, 2017
|
Ah, PettableContainer is such a class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time, "generics" means "cannot be exposed to Objective-C" and certainly "cannot be exposed in the generated header", but there is one exception: imported Objective-C parameterized types, and their extensions. We were previously dropping this on the floor and printing
Foo</* BarType */>in the generated header, which is nonsense.SR-3480