Skip to content

[concurrency] Add support for NonIsolatedAsyncInheritsIsolationFromContext behind a flag #78206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Dec 15, 2024

This is just the initial bit of work. I need to add more test cases/etc... but I wanted to post something that worked end to end to begin getting feedback.

rdar://125193256

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

linux failed in lldb

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@ahoppen ahoppen removed their request for review December 17, 2024 08:31
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

…rameters.

I need this today to add the implicit isolated parameter... but I can imagine us
adding more implicit parameters in the future, so it makes sense to formalize it
so it is easier to do in the future.
…code is doing instead of source inlining it.
Right now it is basically a version of nonisolated beyond a few simple cases
like constructors/destructors where we are pretty sure we want to not support
this.

This is part of my bringup strategy for changing nonisolated/unspecified to be
caller isolation inheriting.
…icit leading parameters for CallerInheritingIsolation isolation.

This does not change region isolation yet to recognize these as effectively
nonisolated.
@gottesmm
Copy link
Contributor Author

gottesmm commented Jan 2, 2025

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge January 2, 2025 22:14
@gottesmm gottesmm merged commit 5bcb696 into swiftlang:main Jan 3, 2025
3 checks passed
@gottesmm gottesmm deleted the rdar141520344-1 branch January 3, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant