LifetimeDependence: redesign dependence scope handling #78228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip borrow scopes that do not actually require lifetime dependence. This will improve LifetimeDependenceScopeFixup.
We can assume that memory is already initialized at the point of a 'yield'; a yield use does not need to invalidate the single-initialization property for temporary stack allocations.
Generalize the design. Extend it to handle different kinds of coroutine dependencies: address/value, scoped/inherited.
Handle all combinations of nested dependence scopes: access scopes, coroutines, and borrow scopes. This is required to enforce ~Escapable _read accessors and unsafeAddress addressors. Fixes rdar://140424699 (Invalid SIL is generated by some passes for certain @Lifetime annotations)
A feature flag is needed so that newer compilers can build older standard library interfaces.
To allow enforcement of trivial borrows.
atrick
requested review from
kavon,
eeckstein,
jckarter,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle arbitrarily nested accesses, borrows, and coroutines.
Handle dependence on variable bindings that hold trivial values.
This overhaul is currently blocking a SILGen fix that adds mark_dependence to unsafeAddress, so that addressors can be used to implement borrowed properties. More tests will be added for addressors at that time.
Fixes rdar://140424699 (Invalid SIL is generated by some passes for certain
@lifetimeannotations)