Skip to content

Fix the runtime and the SDK paths for the swift build compiler case #78249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix the runtime and the SDK paths for the swift build compiler case #78249

merged 1 commit into from
Dec 19, 2024

Conversation

hjyamauchi
Copy link
Contributor

@hjyamauchi hjyamauchi commented Dec 17, 2024 •
edited
Loading

This fix is necessary for the native win arm64 build where arm64 isn't
the first in the WindowsSDKs list.

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi hjyamauchi requested a review from compnerd December 17, 2024 18:03
@hjyamauchi hjyamauchi marked this pull request as ready for review December 17, 2024 18:03
compnerd
compnerd reviewed Dec 17, 2024
View reviewed changes
@hjyamauchi hjyamauchi changed the title Build the runtime of all the Windows architectures before building SDKs Fix the SDK builds when the build arch isn't the first in WindowsSDKs Dec 18, 2024
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

compnerd
compnerd reviewed Dec 18, 2024
View reviewed changes
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi hjyamauchi changed the title Fix the SDK builds when the build arch isn't the first in WindowsSDKs Fix the runtime and the SDK path for the swift build compiler case Dec 18, 2024
@hjyamauchi hjyamauchi changed the title Fix the runtime and the SDK path for the swift build compiler case Fix the runtime and the SDK paths for the swift build compiler case Dec 18, 2024
@hjyamauchi
Fix the runtime and the SDK paths for the swift build compiler case
4a98e37 
This fix is necessary for the native win arm64 build where arm64 isn't
the first in the WindowsSDKs list.
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi hjyamauchi merged commit 7ba4498 into swiftlang:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjyamauchi @compnerd