[6.1] Fix array bounds check optimization for ossa #78253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
changed the title
|
@swift-ci test |
|
@swift-ci test |
tbkka
approved these changes
Dec 19, 2024
While hoisting check_subscript call in ossa, isNativeTypeChecked call is also hoisted. The array value used in the isNativeTypeChecked may not be available if it's lifetime had ended before. Proactively set the array value of the isNativeTypeChecked call to the array value in the check_subscript call.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: While hoisting check_subscript call in ossa,
isNativeTypeCheckedcall is also created in the preheader. The array value used in theisNativeTypeCheckedmay not be available if its lifetime had ended before. Proactively set the array value of theisNativeTypeCheckedcall to the array value in thecheck_subscriptcall.Scope: This fixes an ownership verification error in ArrayBoundsCheckOptimizations.
Original PR: #78231
Risk: Low
Testing: Swift CI testing
Reviewed by: @eeckstein
Issue: rdar://141630349