ClangImporter: Ignore missing imports in SwiftDeclConverter::recordObjCOverride()
#78265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
Xazax-hun
as code owners
tshortli
force-pushed
the
member-import-visibility-imported-objc-overrides
branch
from
a2aaf2c to
9334a02
Compare
…jCOverride(). `recordObjCOverride()` records semantic overrides for imported Obj-C methods. Since these methods are imported from a different language, it doesn't make sense to enforce Swift's member import visibility rules when performing lookups to find overridden methods. Doing so caused the Constrain Solver to lack important information needed to eliminate overloads, resulting in erroneous ambiguities. Resolves rdar://141636723.
tshortli
force-pushed
the
member-import-visibility-imported-objc-overrides
branch
from
9334a02 to
94e678d
Compare
|
@swift-ci please smoke test |
DougGregor
approved these changes
Dec 18, 2024
beccadax
approved these changes
Dec 18, 2024
tshortli
deleted the
member-import-visibility-imported-objc-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recordObjCOverride()records semantic overrides for imported Obj-C methods. Since these methods are imported from a different language, it doesn't make sense to enforce Swift's member import visibility rules when performing lookups to find overridden methods. Doing so caused the Constrain Solver to lack important information needed to eliminate overloads, resulting in erroneous ambiguities.Resolves rdar://141636723.