Sema: Some small cleanups in CSBindings.cpp and related code #78267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
Is this NFC? |
slavapestov
force-pushed
the
incremental-bindings-part-0
branch
from
752aa64 to
d9cdc5c
Compare
slavapestov
requested review from
artemcm,
tshortli and
DougGregor
as code owners
slavapestov
force-pushed
the
incremental-bindings-part-0
branch
from
d9cdc5c to
a450802
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@xedin I finally fixed the test failures here. Also I'm leaving in the commit that adds BindingSet::operator==, which was used for the verification in the old approach I was working on. If we don't need this operator within a week or two let's remove it. |
xedin
approved these changes
Jan 15, 2025
Building the DenseMap in determineBestBindings() is extremely expensive. Also rename getCurrentBindings() to getPotentialBindings().
We're not planning on removing the splitter because it is a big win in some cases, but we want to run it less often since it can also be a source of overhead. This flag allows us to compare performance to understand the tradeoffs better.
This will be used for debugging.
slavapestov
force-pushed
the
incremental-bindings-part-0
branch
from
a450802 to
9a48fed
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a larger set of changes. Not much here.