🍒[build] Respect DEPLOYMENT_VERSION_{IOS|TVOS|WATCHOS} for Simulator targets
#78269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… targets This makes sure that Cxx and CxxStdlib modules are built with consistent deployment targets for iOS Simulator and iOS Device. rdar://141232269 (cherry picked from commit d1a435c)
|
@swift-ci please test |
Xazax-hun
approved these changes
Dec 18, 2024
DougGregor
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This makes sure that Cxx and CxxStdlib modules are built with consistent deployment targets for iOS Simulator and iOS Device. This fixes a regression introduced in b87b263, which caused the Cxx and CxxStdlib binaries to have a deployment target version that is too new.
Scope: This changes the CMake build scripts to pass the correct
-targetflag to swiftc when building binaries for Simulator.Risk: Low, this only changes the build script for CMake targets that override iOS/tvOS/watchOS deployment target.
Testing: Added compiler tests.
Issue: rdar://141232269
Reviewer: @Xazax-hun
Original PR: #78242