Compilation cleanup #7827
Merged
Compilation cleanup #7827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Feb 28, 2017
lib/Driver/Compilation.cpp
Outdated
| @@ -266,6 +266,18 @@ namespace driver { | |||
| parseable_output::emitBeganMessage(llvm::errs(), *BeganCmd, Pid); | |||
| } | |||
|
|
|||
| void | |||
| dependencyLoadFailed(StringRef DependenciesFile, bool Warn=true) { | |||
| if (Warn) | |||
There was a problem hiding this comment.
I'm on the fence about this. On the one hand, we might get more feedback from users, but on the other they may end up with a warning they can't silence. (Neither Xcode nor SwiftPM expose a switch to turn off incremental builds.)
jrose-apple
reviewed
Feb 28, 2017
lib/Driver/Compilation.cpp
Outdated
| } | ||
| DeferredCommands.clear(); |
|
I'm going to trust you that all the refactoring parts don't change anything; chopping up |
|
Pushed a couple updates to dial back the diagnostic chatter. |
graydon
force-pushed
the
compilation-cleanup
branch
from
50ebd69 to
5c19107
Compare
graydon
force-pushed
the
compilation-cleanup
branch
from
5c19107 to
1c3a54b
Compare
|
@swift-ci please test and merge |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some generic refactoring and tidying in the driver, mostly splitting
Compilation::performJobsImplinto enough pieces (and turning various lambdas and locals into named and commented methods
and members) that I can follow what it's doing. This is prep work for more involved debugging of
driver issues; I realized I couldn't really understand the structure of
performJobsImplbefore.Along the way, fixed a few minor, mostly-logging issues:
rdar://30792302