[6.1] Remove diagnostic error for importing non ossa module to ossa module when EBM is not enabled #78276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when EBM is not enabled
|
@swift-ci test |
tbkka
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Importing non-ossa module to ossa module in implicit builds is supported with one time recompilation of the non-ossa module. #77314 introduced an error when importing non-ossa module to ossa module whenever
EnableRecompilationToOSSAModuleis not set. Remove this error since we have to support old swiftinterfaces with this scenario.Scope: Fixes compilation error while building old Distributed.swiftinterface and Synchronization.swiftinterface with newer compilers.
Issues: rdar://141576869
Original PRs: #78274
Risk: Low.
Testing: Tested with old Distributed.swiftinterface and Synchronization.swiftinterface
Reviewers: @tshortli