Skip to content

[6.1][Caching] Fix the cache replay bugs from driver C APIs #78282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 19, 2024
Merged

[6.1][Caching] Fix the cache replay bugs from driver C APIs #78282

merged 6 commits into from
Dec 19, 2024

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Dec 19, 2024 •
edited
Loading

  • Explanation:This patch contains a serials of changes that targeted to fix the missing function in C APIs when replaying results from build system. It teaches the driver/build-system to replay the newly specialized makefile dependency files and symbol graph files correctly.
  • Scope: This fixes the wrong or missing outputs when there is a cache hit. The build system will fail to the replay make style dependency file and symbol graph output when that happens.
  • Issues:rdar://141567785
  • Original PRs:[Caching] Fix the cache replay bugs from driver C APIs #78279
  • Risk:Low. Swift Caching only.
  • Testing:Added UnitTests
  • Reviewers: @benlangmuir @rastogishubham

@cachemeifyoucan
[MCCAS] Fix uninitialzied variables in CASID file output
56bcc63 
Fix uninitalized variables in IRGen options. Those options are
initialized with `|=` so it is important to initialize them to false.
@cachemeifyoucan
[Caching] Fix cache replay logics for makefile dependency file
2785df7 
Make sure the driver replay logics from C API can replay makefile
dependency file correctly.

rdar://141567785
@cachemeifyoucan
[MCCAS] Simplify MCCAS replay logic. NFC
94fdc89
@cachemeifyoucan
[Caching] symbol-graph output directory path is cache invariant
0bea1bf 
Make output directory path cache invariant.
@cachemeifyoucan
[Caching] Fix symbol graph output from driver APIs
53ce9b9 
Add the logics to replay symbol graph output from driver APIs.
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner December 19, 2024 00:28
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
[Caching] Downgrade output loading error to a warning
c696593 
If the output loading failed after cache key lookup, treat that as a
warning and resume as if that is a cache miss. This is not a valid
configuration for builtin CAS but can happen for a remote CAS service
that failed to serve the output. Instead of failing, we should continue
to compile to avoid disruptive failures.

rdar://140822432
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

nkcsgexi
nkcsgexi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a safe fix to me.

@cachemeifyoucan cachemeifyoucan merged commit 02d91e8 into swiftlang:release/6.1 Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cachemeifyoucan @nkcsgexi