AST: Introduce SemanticAvailableAttr
#78284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
xymus,
hborla,
slavapestov,
xedin,
eeckstein,
jckarter,
zoecarver,
hyp,
egorzhdan,
Xazax-hun and
artemcm
as code owners
|
@swift-ci please test |
This new attribute iterator returned from the query makes it simpler to implement algorithms that need access to both the `AvailableAttr *` and its corresponding `AvailabilityDomain`. This is also work towards making it possible to return an optional `AvailabilityDomain` from `Decl::getDomainForAvailableAttr()`.
This convenience returns an optional `SemanticAvailableAttr` (since in the future, lookup of the `AvailabilityDomain` can fail). It replaces `Decl::getDomainForAvailableAttr()`, since most callers will need to form a `SemanticAvailableAttr` with the resulting domain anyways.
tshortli
force-pushed
the
semantic-available-attr
branch
from
a4e5f24 to
111661e
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an
@availableattribute'sAvailabilityDomaincan be resolved eagerly when parsing, but in the future resolving some availability domains will require name lookup which will have to be done lazily after parsing and may also fail.SemanticAvailableAttris a new type that wraps anAvailableAttrand its resolvedAvailabilityDomain. It should be used throughout the compiler for queries and operations that require validAvailableAttrsthat have successfully resolved domains.This PR only partially adopts
SemanticAvailableAttr. The remainder of the adoption should happen piecemeal, driven by moving the majority of the methods onAvailableAttrover toSemanticAvailableAttruntil all that's left onAvailableAttris the raw, parsed representation which is only accessed throughSemanticAvailableAttr.