[SwiftCompilerSources] Use interpolation instead of String(describing:)
#78288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
String interpolation ( |
…g:)` `String(describing:)` does a bunch of dynamic casts that can be pretty slow. Use interpolation instead, which bypasses them. For `swift-frontend`, this brings the time taken for type-checking an empty file down from ~100ms to ~70ms. For `swift build`, this brings the time taken for a null build down from ~600ms to ~450ms (the larger delta is presumably due to the fact that there's much more Swift code in `swift-package`).
hamishknight
force-pushed
the
use-typename
branch
from
6976d72 to
f728466
Compare
|
Nice! Updated to use interpolation |
|
@swift-ci please smoke test |
hamishknight
changed the title
_typeName instead of String(describing:)String(describing:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String(describing:)does a bunch of dynamic casts that can be pretty slow. Use interpolation instead, which bypasses them.swift-frontend, this brings the time taken for type-checking an empty file down from ~100ms to ~70ms.swift build, this brings the time taken for a null build down from ~600ms to ~450ms (the larger delta is presumably due to the fact that there's much more Swift code inswift-package).