[xcodegen] Avoid an intermediate String #78291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to create an intermediate String when escaping characters in the plist.
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
Dec 19, 2024
| mutating func appendEscaped(_ string: String) { | ||
| for char in string.utf8 { | ||
| if char == UInt8(ascii: "\\") || char == UInt8(ascii: "\"") { | ||
| append(UInt8(ascii: "\\")) |
There was a problem hiding this comment.
Suggested change
| append(UInt8(ascii: "\\")) | |
| append(UInt8(ascii: #"\"#)) |
🙂
There was a problem hiding this comment.
When there's only a single character to escape I tend to prefer just writing the backslash, especially as things like #"""# look weird. I think I'd rather keep things locally consistent here, I don't feel too strongly about it though
There was a problem hiding this comment.
I see. I do not actually have a preference, but I was curious about yours, on the off chance that a raw string had occurred to you.
AnthonyLatsis
added
contributor experience
swift-xcodegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to create an intermediate String when escaping characters in the plist.