Sema: Remove ConstraintKind::OneWayBindParam and ConstraintKind::OneWayEqual #78301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
artemcm,
tshortli and
DougGregor
as code owners
xedin
approved these changes
Dec 19, 2024
|
@swift-ci please test source compatibility |
|
@swift-ci Please smoke test |
|
For posterity. This might cause a difference in behavior for things like: because |
|
I think we can follow-up with a small refactoring of |
slavapestov
force-pushed
the
remove-one-way-constraints
branch
from
8cc6da2 to
2d48060
Compare
AnthonyLatsis
approved these changes
Dec 20, 2024
…tely Instead of using `one-way` constraints, just like in closure contexts for-in statements should type-check their `where` clauses separately. This also unifies and simplifies for-in preamble handling in the solver.
…al base in diagnostic mode Re-introduce unsolved member constraint when optional object is a type variable or member until it's bound, otherwise it's impossible to tell whether unwrapped base would have a member or not.
…ied to a member `TVO_PrefersSubtypeBinding` in this case is intended to support references to Objective-C imported members that can be force unwrapped before being used i.e. accessing an overloaded method on `AnyObject` should always prefer an overload that returns a subtype: ``` @objc class A: NSObject { @objc func test() -> A { } @objc func test() -> B { } } func test(obj: AnyObject) { obj.test!() } ``` where `B` is a subtype of `A` should result in selection of `() -> B`.
xedin
force-pushed
the
remove-one-way-constraints
branch
from
a0fbd89 to
80a988e
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility debug |
|
Debug config failures are unrelated to these changes, main fails the same way - https://ci.swift.org/job/swift-main-source-compat-suite-debug/989/ |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Feb 25, 2025
I had to revert swiftlang#78301 to fix rdar://143338891. This now brings back the change, but without deleting code; instead, it's guarded by the -disable-optimized-restrictions flag. Once the flag is removed, I will once again completely delete OneWayEqual constraints.
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Feb 25, 2025
I had to revert swiftlang#78301 to fix rdar://143338891. This now brings back the change, but without deleting code; instead, it's guarded by the -disable-optimized-restrictions flag. Once the flag is removed, I will once again completely delete OneWayEqual constraints.
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Feb 27, 2025
I had to revert swiftlang#78301 to fix rdar://143338891. This now brings back the change, but without deleting code; instead, it's guarded by the -disable-optimized-restrictions flag. Once the flag is removed, I will once again completely delete OneWayEqual constraints.
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Feb 28, 2025
I had to revert swiftlang#78301 to fix rdar://143338891. This now brings back the change, but without deleting code; instead, it's guarded by the -disable-optimized-restrictions flag. Once the flag is removed, I will once again completely delete OneWayEqual constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.