[DCE] Don't complete lifetimes of erased values. #78306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than reusing the source of the dyn_cast.
Set CallsChanged when appropriate and increment NumDeletedInsts.
DCE may enqueue a value for lifetime completion and later on erase the instruction that defines that value. When erasing an instruction, erase each of its results from the collection of values to complete. rdar://141560546
nate-chandler
force-pushed
the
rdar141560546
branch
from
7509c17 to
6d9ae19
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCE may enqueue a value for lifetime completion and later on erase the instruction that defines that value. When erasing an instruction, erase each of its results from the collection of values to complete.
rdar://141560546