Fix parsing of @_unavailableFromAsync #78313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
requested review from
ktoso,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
rintaro
reviewed
Dec 20, 2024
| SourceLoc labelLoc; | ||
| parseOptionalArgumentLabel(label, labelLoc, /*isAttr=*/true); | ||
|
|
||
| if (label.empty()) { |
There was a problem hiding this comment.
Considering (_: "message", using labelLoc is safer.
Suggested change
| if (label.empty()) { | |
| if (labelLoc.isInvalid()) { |
Same for the newCode check below
There was a problem hiding this comment.
Added more test cases covering these combos, reworked the code to behave more nicely.
There’s a very easy to reach `llvm_unreachable()` in this code which ought to be a diagnostic, as well as a couple of other issues. Rework it into something that’s a bit better at handling the edge cases.
beccadax
force-pushed
the
llvm_reachable
branch
from
9d3865b to
90f7724
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s a very easy to reach
llvm_unreachable()in this code which ought to be a diagnostic, as well as a couple of other issues. Rework it into something that’s a bit better at handling the edge cases.