[cherry-pick][DebugInfo] Fix debug info round tripping of types inside functions #78330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Types with @_originallyDefinedIn cannot be round tripped, Types declared inside functions have their mangling affected by the function signature. If the generic signature mentions an @_originallyDefinedIn type, the type inside the function cannot be round tripped either. This commit disables round tripping for this scenario. (cherry picked from commit d75bde3)
augusto2112
force-pushed
the
fix-orig-def-type-in-func-6
branch
from
34e0d0e to
2720862
Compare
|
@swift-ci test |
Now that mangling for the debugger respects originally defined in, this is not needed anymore. (cherry picked from commit 398ded5)
augusto2112
force-pushed
the
fix-orig-def-type-in-func-6
branch
from
47b0b91 to
eaf307b
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types with @_originallyDefinedIn cannot be round tripped,
Types declared inside functions have their mangling affected by the function signature. If the generic signature mentions an @_originallyDefinedIn type, the type inside the function cannot be round tripped either.
This commit disables round tripping for this scenario.
(cherry picked from commit 3bb29ca)