Skip to content

Remove outdated warning about swift interfaces without library evolution #78342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove outdated warning about swift interfaces without library evolution #78342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions include/swift/AST/DiagnosticsFrontend.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,6 @@ WARNING(warn_unsupported_module_interface_swift_version,none,
"module interfaces are only supported with Swift language version 5 "
"or later (currently using -swift-version %0)",
(StringRef))
WARNING(warn_unsupported_module_interface_library_evolution,none,
"module interfaces are only supported with -enable-library-evolution",
())
ERROR(error_extracting_version_from_module_interface,none,
"error extracting version from module interface", ())
ERROR(unsupported_version_of_module_interface,none,
Expand Down
4 changes: 0 additions & 4 deletions lib/FrontendTool/FrontendTool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ printModuleInterfaceIfNeeded(llvm::vfs::OutputBackend &outputBackend,
diag::warn_unsupported_module_interface_swift_version,
LangOpts.isSwiftVersionAtLeast(4, 2) ? "4.2" : "4");
}
if (M->getResilienceStrategy() != ResilienceStrategy::Resilient) {
diags.diagnose(SourceLoc(),
diag::warn_unsupported_module_interface_library_evolution);
}
return withOutputPath(diags, outputBackend, outputPath,
[M, Opts](raw_ostream &out) -> bool {
return swift::emitSwiftInterface(out, Opts, M);
Expand Down
2 changes: 0 additions & 2 deletions test/ModuleInterface/unsupported-configurations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@
// RUN: ls %t/empty.swiftinterface

// CHECK-DAG: warning: module interfaces are only supported with Swift language version 5 or later (currently using -swift-version [[VERSION]])
// CHECK-DAG: warning: module interfaces are only supported with -enable-library-evolution

// CHECK-VERSION-ONLY-NOT: warning:
// CHECK-VERSION-ONLY: warning: module interfaces are only supported with Swift language version 5 or later (currently using -swift-version [[VERSION]])
// CHECK-VERSION-ONLY-NOT: warning:

// CHECK-EVOLUTION-ONLY-NOT: warning:
// CHECK-EVOLUTION-ONLY: warning: module interfaces are only supported with -enable-library-evolution
// CHECK-EVOLUTION-ONLY-NOT: warning:

// NEGATIVE-NOT: warning:
Expand Down