[cxx-interop] Estend _SwiftifyImport with basic std::span support #78352
Conversation
This is a preliminary PR to transform nonescaping std::span parameters to Swift's Span type in safe wrappers. To hook this up with ClangImporter, we will need generalize the noescape attribute to non-pointer types (PR is already in review). To transform potentially escaping spans and spans in the return position, a follow-up PR will add lifetime annotation support. This is a building block towards rdar://139074571.
Xazax-hun
force-pushed
the
gaborh/cxx-span-overload
branch
from
d65bf9b to
b0bb995
Compare
|
@swift-ci please smoke test |
| for (idx, param) in signature.parameterClause.parameters.enumerated() { | ||
| let typeName = try getTypeName(param.type).text; | ||
| if let desugaredType = typeMappings[typeName] { | ||
| if desugaredType.starts(with: "span") { |
There was a problem hiding this comment.
I think this will cause an issue if any type alias from C/C++ where the desugared type starts with "span", right? It's probably a good idea to add a cxxSpan option to the _SwiftifyInfo enum.
There was a problem hiding this comment.
Oh, I wanted to update this code snippet. I don't think we need an enum for this, but I'll make the name matching more precise.
There was a problem hiding this comment.
In the meantime, I am working on a follow-up PR. The content of the string we are matching against depends on how we generate the typeMapping in ClangImporter. Would you be OK if this part would stay as is and I only changed it in the follow up where this starts to work end to end? Alternatively, I can backport some code to this PR.
There was a problem hiding this comment.
The follow-up PR where this logic changes: #78422
This is a preliminary PR to transform nonescaping std::span parameters to Swift's Span type in safe wrappers. To hook this up with ClangImporter, we will need generalize the noescape attribute to non-pointer types (PR is already in review). To transform potentially escaping spans and spans in the return position, a follow-up PR will add lifetime annotation support. This is a building block towards rdar://139074571.