[CSOptimizer] Few tweaks to make unapplied disjunction and literal array arguments faster #78357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility release |
xedin
force-pushed
the
too-complex-with-count
branch
from
e684fe1 to
e4b35f9
Compare
|
@swift-ci please test |
xedin
force-pushed
the
too-complex-with-count
branch
from
e4b35f9 to
8a03ac0
Compare
xedin
changed the title
When disjunction is not applied, don't only bump its score but also favor all of the choices that don't require application because selection algorithm uses that for comparison. This is important for situation when property is overload with a method i.e. `Array.count`.
xedin
force-pushed
the
too-complex-with-count
branch
from
8a03ac0 to
77caa71
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…terals Match `[...]` to Array<...> and/or `ExpressibleByArrayLiteral` conforming types. This is very helpful for expressions like: `[...] + [...]`.
xedin
force-pushed
the
too-complex-with-count
branch
from
77caa71 to
8a304f8
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility release |
…al array handling
xedin
force-pushed
the
too-complex-with-count
branch
from
8e29d44 to
cfd34e5
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disjunction is not applied, don't only bump its score but also favor all of the choices that don't require application because selection algorithm uses that for comparison.
This is important for situation when property is overload with a method i.e.
Array.count.Extend candidate/parameter matching to support array literals
Match
[...]to Array<...> and/orExpressibleByArrayLiteralconforming types. This is very helpful for expressions like:
[...] + [...].