[Sema] Remove RecontextualizeClosures #78367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to walk the lazy initializer in the accessor, but when this code was written that wasn't a walking option. Switch to using `LazyInitializerWalking::InAccessor`.
Expose a generic `TypeChecker::contextualizeExpr` to invoke it.
We want these to be contextualized as part of their implicit getter, avoid attempting to contextualize as part of the PatternBindingDecl. This avoid incorrectly computing captures as part of the PatternBindingDecl; as such we also need to update ActorIsolationChecker to walk lazy inits as part of the accessor.
Merge with ContextualizeClosuresAndMacros, and rename to ContextualizationWalker given that it re-contextualizes a whole bunch of AST nodes now. This ensures we correctly handle cases such as decls in if/switch expressions within autoclosures.
If the decl itself is a DeclContext, make sure to update its parent too.
Make sure we walk into any non-DeclContext decl, allowing us to e.g walk into VarDecls to correctly re-contextualize their accessors in an outer autoclosure. I don't *think* this currently makes much of a difference since the mangling today uses the DeclContext of the VarDecl, but it seems like the right thing to do regardless.
hamishknight
force-pushed
the
in-context
branch
from
05d33b9 to
6a1f8c7
Compare
|
@swift-ci please test source compatibility |
hamishknight
requested review from
jckarter,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
xedin
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with ContextualizeClosuresAndMacros, and rename to ContextualizationWalker given that it re-contextualizes a whole bunch of AST nodes now. This ensures we correctly handle cases such as decls in if/switch expressions within autoclosures.
Resolves #75294
rdar://131973802