[AutoDiff] Allow closure differentiation when used as default arg val #78373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @asl @JaapWijnen @rxwei |
kovdan01
requested review from
eeckstein,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Would be glad to see feedback from everyone interested |
2 similar comments
|
Would be glad to see feedback from everyone interested |
|
Would be glad to see feedback from everyone interested |
|
This PR LGTM after #77615 is merged |
If the default argument generator (and, consequently, the function taking this default argument) has public visibility, it's OK to have a closure (which always has private visibility) as the default value of the argument.
kovdan01
force-pushed
the
implicit-diff-closure-on-top-77615
branch
from
6cdff4f to
40e5eb2
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
asl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default argument generator (and, consequently, the function taking
this default argument) has public visibility, it's OK to have a closure
(which always has private visibility) as the default value of the argument.