Optimizer: enable SILCodeMotion in OSSA, but only for trivial values. #78384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci please test source compatibility |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
…nstructions When replacing all uses, ignore existing borrowed-from instructions. Fixes a SIL verifier error.
… in OwnershipOptUtils
to-do: we should eventually remove code motion of retain and release instructions and implement them as semantic ARC optimizations in OSSA.
eeckstein
force-pushed
the
enable-code-motion-in-ossa
branch
from
f9c0890 to
53d78ab
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
eeckstein
requested review from
atrick,
meg-gupta and
nate-chandler
and removed request for
xymus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to-do: we should eventually remove code motion of retain and release instructions and implement them as semantic ARC optimizations in OSSA.
Also fix a problem when incrementally updating borrowed-from instructions in the PhiUpdater, which was uncovered by the other change.
This is part of fixing regressions when enabling OSSA modules:
rdar://140229560