[6.1] TypeCheckType: Unconditionally warn about missing existential any until a future language mode
#78389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavio12345300
approved these changes
Dec 31, 2024
AnthonyLatsis
force-pushed
the
tuber-magnatum-6.1
branch
from
a5f8bfd to
a198e94
Compare
AnthonyLatsis
force-pushed
the
tuber-magnatum-6.1
branch
from
a198e94 to
855f81d
Compare
AnthonyLatsis
force-pushed
the
tuber-magnatum-6.1
branch
from
855f81d to
e417268
Compare
AnthonyLatsis
changed the title
ExistentialAny warn rather than error until Swift 7any until Swift 7
…ntil Swift 7 swiftlang#72659 turned out to have some source compatibility fallout that we need to fix. Instead of introducing yet another brittle compatibility hack, stop emitting errors about a missing `any` altogether until a future language mode. Besides resolving the compatibility issue, this will encourage developers to adopt any sooner and grant us ample time to gracefully address any remaining bugs before the source compatibility burden resurfaces. A subsequent commit adds a diagnostic group that will allow users to escalate these warnings to errors with `-Werror ExistentialAny`.
AnthonyLatsis
force-pushed
the
tuber-magnatum-6.1
branch
from
e417268 to
b483d09
Compare
Allow users to escalate `any` syntax warnings to errors with `-Werror ExistentialAny`.
AnthonyLatsis
force-pushed
the
tuber-magnatum-6.1
branch
from
b483d09 to
146b217
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
AnthonyLatsis
changed the title
any until Swift 7any until a future language mode
hborla
approved these changes
Feb 18, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: TypeCheckType: Fix some bugs in the
anysyntax checker #72659 turned out to have some source compatibility fallout that we need to fix. Instead of introducing yet another brittle compatibility hack, stop emitting errors about a missinganyaltogether until a future language mode.Besides resolving the compatibility issue, this will encourage developers to adopt
anysooner and grant us ample time to gracefully address any remaining bugs before the source compatibility burden resurfaces.Users can still escalate these warnings to errors with
-Werror ExistentialAny.Scope:
anysyntax diagnosis.Issues: rdar://134953066.
Original PRs: TypeCheckType: Unconditionally warn about missing existential
anyuntil a future language mode #78459Risk: Low.
Testing: Source compatibility suite.
Reviewers: @slavapestov