DiagnosticEngine: Fix escalation for wrapped diagnostics #78398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test macOS |
|
cc @DmT021 |
AnthonyLatsis
force-pushed
the
micronecta-scholtzi
branch
from
cda25bd to
9e70208
Compare
|
@swift-ci please smoke test macOS |
DmT021
reviewed
Jan 3, 2025
| void setWarningAsErrorForDiagID(DiagID id, bool value) { | ||
| /// Sets whether warnings belonging to the diagnostic group identified by | ||
| /// `id` should be escalated to errors. | ||
| void setWarningsAsErrorsForDiagGroupID(DiagGroupID id, bool value) { |
There was a problem hiding this comment.
It took me a moment to understand why it's a valid change for the case when we apply WarningAsErrorRule with TargetAll. But it seems it's ok as all the uncategorized warnings have the no_group group which will be stored in this BitVector like the others.
I'd leave a comment about it though.
There was a problem hiding this comment.
Sure. Will add a test too.
AnthonyLatsis
force-pushed
the
micronecta-scholtzi
branch
from
9e70208 to
f06a058
Compare
|
@swift-ci please smoke test macOS |
DmT021
approved these changes
Jan 7, 2025
DougGregor
approved these changes
Jan 7, 2025
|
@swift-ci please smoke test |
…ostic group This group has not shipped yet and was added mainly to support test coverage for d56b7df. Now that we have unit tests for this, delete the group, pending discussion.
|
@swift-ci please smoke test Linux |
AnthonyLatsis
force-pushed
the
micronecta-scholtzi
branch
from
f06a058 to
c4793b6
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
AnthonyLatsis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped diagnostics were not escalated to errors because the check was based on the diagnostic ID, which is that of the wrapper diagnostic in this case. Switch to tracking whether escalation was enabled for a given group instead.