[6.1] IRGen: OutliningCollector's bindPolymorphicParameters needs to disambiguate between Formal and Representational metadata types #78424
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disambiguate between Formal and Representational metadata types Explaination: A recent change removed the usage of LocalTypeDataKind when populating the local type metadata cache. This change reintroduces it. Scope: Whenever representational metadat types are called for a compiler crash could be the result. Risk: Low. Should restore previous behavior when representational types are called for. Original PR: swiftlang#78423 rdar://141961121
|
@swift-ci test |
tbkka
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explaination: A recent change removed the usage of LocalTypeDataKind when populating the local type metadata cache. This change reintroduces it.
Scope: Whenever representational metadat types are called for a compiler crash could be the result.
Risk: Low. Should restore previous behavior when representational types are called for.
Original PR: #78423
rdar://141961121