🍒[6.1] Frontend: add an ABI checker flag to avoid downgrading detected ABI breakages into warnings. #78429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reakages into warnings. rdar://122325279
|
@swift-ci please test |
bnbarham
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: By default in certain build environments, we downgrade ABI checker issues to warnings to prevent blocking the build process. Several existing users raised concerns about this for escaping significant ABI breakages. Therefore, an ABI checker flag is introduced in this PR to allow users to opt-in a mode where ABI breakages are considered fatal.
Scope: ABI checker
Risk: Very Low. No existing behaviors are altered except adding an argument
Original PR: Frontend: add an ABI checker flag to avoid downgrading detected ABI breakages into warnings. #78418
Resolves: rdar://122325279
Reviewer: @tshortli