Skip to content

Sema: Do better at diagnosing missing each #78434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

Sema: Do better at diagnosing missing each #78434

merged 2 commits into from
Jan 7, 2025

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Jan 4, 2025 •
edited
Loading

Resolves #78393.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@xedin
Copy link
Contributor

xedin commented Jan 4, 2025

I will take a look on Monday, need to page some of this back in… One non-functional suggestion would be to use isExpr instead of isa_*, we really ought to switch getParentExpr to getParent that returns ASTNode now that we can handle patterns and such…

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis merged commit 33f03f7 into swiftlang:main Jan 7, 2025
3 checks passed
@AnthonyLatsis AnthonyLatsis deleted the each-pack branch January 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler crash when referencing parameter pack of functions
2 participants
@AnthonyLatsis @xedin