[cxx-interop] Diagnose ObjC APIs returning SWIFT_SHARED_REFERENCE types #78458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahadnayyar
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
beccadax and
ian-twilightcoder
as code owners
Xazax-hun
reviewed
Jan 7, 2025
test/Interop/Cxx/objc-correctness/objc-returning-cxx-frt-diagnostics.swift
Outdated
Show resolved
Hide resolved
fahadnayyar
force-pushed
the
returns-retained-objc-diagnostics
branch
2 times, most recently
from
8db53ac to
eba183a
Compare
j-hui
reviewed
Jan 8, 2025
test/Interop/Cxx/objc-correctness/objc-returning-cxx-frt-diagnostics.swift
Outdated
Show resolved
Hide resolved
test/Interop/Cxx/objc-correctness/objc-returning-cxx-frt-diagnostics.swift
Outdated
Show resolved
Hide resolved
fahadnayyar
force-pushed
the
returns-retained-objc-diagnostics
branch
from
eba183a to
6f5c98c
Compare
Xazax-hun
approved these changes
Jan 8, 2025
fahadnayyar
force-pushed
the
returns-retained-objc-diagnostics
branch
from
6f5c98c to
1c140ce
Compare
fahadnayyar
force-pushed
the
returns-retained-objc-diagnostics
branch
from
1c140ce to
69332f7
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding diagnostic support (related to SWIFT_RETURNS_(UN)RETAINED annotations) for ObjC APIs returning SWIFT_SHARED_REFERENCE types
rdar://142500663