Fix build option for Synchronization and Distributed #78460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These utilities are called from MandatorPerformanceOptimizations which can run on serialized non-ossa functions. Add a bailout to handle this case.
|
@swift-ci test |
tshortli
reviewed
Jan 7, 2025
| @@ -3169,9 +3169,12 @@ static AllocationInst *getOptimizableAllocation(SILInstruction *i) { | |||
| } | |||
|
|
|||
| bool swift::optimizeMemoryAccesses(SILFunction *fn) { | |||
| if (!fn->hasOwnership()) { | |||
There was a problem hiding this comment.
Did fixing the presence of the flag reveal some new issues?
There was a problem hiding this comment.
Yeah. Now that Synchronization and Distributed are serialized in non-ossa, I had to add these bailouts since we run mandatory optimizations on serialized functions as well.
|
@swift-ci smoke test |
tshortli
approved these changes
Jan 7, 2025
|
@swift-ci test Linux platform |
|
@swift-ci test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77314 incorrectly named the parameter name which resulted in the
-enable-ossa-modulesbeing present in the swift interfaces of Synchronization and Distributed. This PR fixes the cmake function parameter name while querying for IMPORTS_NON_OSSA by using the right prefix used incmake_parse_arguments.