[OSSACompleteLifetime] Skip mark_dependence [unresolved]. #78466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such instructions can appear outside the lifetime of the begin_access which they use. They are eventually rewritten not to have that flag and not to appear outside the access scope they refer to. rdar://142424000
|
@swift-ci please test |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test source compatibility |
|
I don't think this mark_dependence should have been rewritten to depend on the begin_access address. I think it's a peculiarity of LifetimeDependenceScopeFixup on trivial values. Let me see if that can be fixed. |
|
Closing in favor of #78482 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such instructions can appear outside the lifetime of the
begin_accesswhich they use. They are eventually rewritten not to have that flag and not to appear outside the access scope they refer to.rdar://142424000