Skip to content

[Test] Fix a typo in the test util python script #78475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cachemeifyoucan
Copy link
Contributor

Fix the typo in GenerateExplicitModuleMap.py where the modulePath is mis-spelled. Use the module path from the dependency output json file directly instead, which means the script can be used to generate non-caching build module map as well since the module path actually matters for those builds.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test linux platform

Fix the typo in GenerateExplicitModuleMap.py where the modulePath is
mis-spelled. Use the module path from the dependency output json file
directly instead, which means the script can be used to generate
non-caching build module map as well since the module path actually
matters for those builds.
@cachemeifyoucan cachemeifyoucan force-pushed the eng/fix-typo-python-script branch from 704f11c to ef99096 Compare January 8, 2025 19:22
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan merged commit 8258b1b into swiftlang:main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants