🍒 [cxx-interop] Add support for SWIFT_RETURNS_(UN)RETAINED for ObjC APIs returning C++ FRT #78484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s returning C++ FRT rdar://135360972
fahadnayyar
force-pushed
the
fahadnayyar/6.1-returns-retained-objc-support
branch
from
678a2d0 to
c66996c
Compare
|
@swift-ci please test |
Xazax-hun
approved these changes
Jan 8, 2025
egorzhdan
approved these changes
Jan 8, 2025
|
This seems small enough that we can take it still |
DougGregor
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Adding support for new annotations SWIFT_RETURNS_(UN)RETAINED for ObjC APIs just like we did for C++ APIs in this PR: #75897
Scope: Not a source breaking change. Just adding support for new annotations for ObjC APIs.
Risk: Low, this logic would trigger only when users start using new annotations.
Reviewer: @egorzhdan @Xazax-hun @j-hui
Original PR: #78230