Skip to content

Ignore -enable-testing when compiling for the debugger on getEffectiv… #78486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

augusto2112
Copy link
Contributor

…eAccess

Compiling for the debugger relaxes certain restrictions, such as accessing private members of a type. When compiling code for accessing a member of a module built with -enable-testing, the compiler might generate the access behind a dispatch thunk, which would be correct for "regular" code, but not for the debugger, since dispatch thunks don't exist for private members.

rdar://140300320

…eAccess

Compiling for the debugger relaxes certain restrictions, such as
accessing private members of a type. When compiling code for accessing a
member of a module built with -enable-testing, the compiler might
generate the access behind a dispatch thunk, which would be correct
for "regular" code, but not for the debugger, since dispatch thunks
don't exist for private members.

rdar://140300320
@augusto2112
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but this also looks like it could be tested in source->SIL test with the right flags?

@augusto2112
Copy link
Contributor Author

Closing in favor of #78728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants